Change in openvpn[master]: Use ASN1_BIT_STRING_get_bit to check for netscape certificate usage
A message that is not in the archive (sent off-list or not yet received): gerrit.1774445432000.I77500d435f212a4bf42ee8cfca07d0285fe694f2@...2715...
plaisthos has uploaded this change for review. ( http://gerrit.openvpn.net/c/openvpn/+/1587?usp=email )
Change subject: Use ASN1_BIT_STRING_get_bit to check for netscape certificate usage
......................................................................
Use ASN1_BIT_STRING_get_bit to check for netscape certificate usage
The ASN_BIT_STRING object has become opaque in OpenSSL 4.0. So instead of accessing the internal, we have to use a method now to check these attributes.
The bit counting in ANS.1 and of this method is a bit strange and it will count bits from the left instead of the right, so the previous mask of 0x80 for clients is now 0 and 0x40 for server is now 1.
---
M src/openvpn/ssl_verify_openssl.c
1 file changed, 5 insertions(+), 4 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/87/1587/1
src/openvpn/ssl_verify_openssl.c +5 -4
@@ -626,7 +626,8 @@ {ASN1_BIT_STRING *ns; ns =X509_get_ext_d2i (peer_cert, NID_netscape_cert_type,NULL ,NULL ); - result = (ns && ns->length >0 && (ns->data[0 ] &NS_SSL_CLIENT )) ?SUCCESS :FAILURE ; +// bit 0 is to check if certificate is the client certificate + result =ASN1_BIT_STRING_get_bit (ns,0 ) ?SUCCESS :FAILURE ;if (result ==SUCCESS ) { msg(M_WARN, "X509: Certificate is a client certificate yet it's purpose "
@@ -652,9 +653,9 @@*/ if (result ==FAILURE ) { -ASN1_BIT_STRING *ns; - ns =X509_get_ext_d2i (peer_cert, NID_netscape_cert_type,NULL ,NULL ); - result = (ns && ns->length >0 && (ns->data[0 ] &NS_SSL_SERVER )) ?SUCCESS :FAILURE ; +ASN1_BIT_STRING *ns =X509_get_ext_d2i (peer_cert, NID_netscape_cert_type,NULL ,NULL ); +// Server bit is 1 for ASN1_BIT_STRING_get_bit + result =ASN1_BIT_STRING_get_bit (ns,1 ) ?SUCCESS :FAILURE ;if (result ==SUCCESS ) { msg(M_WARN, "X509: Certificate is a server certificate yet it's purpose "
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1587?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I77500d435f212a4bf42ee8cfca07d0285fe694f2
Gerrit-Change-Number: 1587
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
plaisthos has uploaded a new patch set (#2). ( http://gerrit.openvpn.net/c/openvpn/+/1587?usp=email )
Change subject: Use ASN1_BIT_STRING_get_bit to check for netscape certificate usage
......................................................................
Use ASN1_BIT_STRING_get_bit to check for netscape certificate usage
The ASN_BIT_STRING object has become opaque in OpenSSL 4.0. So instead of accessing the internal, we have to use a method now to check these attributes.
The bit counting in ANS.1 and of this method is a bit strange and it will count bits from the left instead of the right, so the previous mask of 0x80 for clients is now 0 and 0x40 for server is now 1.
---
M src/openvpn/ssl_verify_openssl.c
1 file changed, 5 insertions(+), 4 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/87/1587/2
src/openvpn/ssl_verify_openssl.c +5 -4
@@ -624,7 +624,8 @@ {ASN1_BIT_STRING *ns; ns =X509_get_ext_d2i (peer_cert, NID_netscape_cert_type,NULL ,NULL ); - result = (ns &&ASN1_STRING_length (ns) >0 && (ASN1_STRING_get0_data (ns)[0 ] &NS_SSL_CLIENT )) ?SUCCESS :FAILURE ; +// bit 0 is to check if certificate is the client certificate + result =ASN1_BIT_STRING_get_bit (ns,0 ) ?SUCCESS :FAILURE ;if (result ==SUCCESS ) { msg(M_WARN, "X509: Certificate is a client certificate yet it's purpose "
@@ -650,9 +651,9 @@*/ if (result ==FAILURE ) { -ASN1_BIT_STRING *ns; - ns =X509_get_ext_d2i (peer_cert, NID_netscape_cert_type,NULL ,NULL ); - result = (ns &&ASN1_STRING_length (ns) >0 && (ASN1_STRING_get0_data (ns)[0 ] &NS_SSL_SERVER )) ?SUCCESS :FAILURE ; +ASN1_BIT_STRING *ns =X509_get_ext_d2i (peer_cert, NID_netscape_cert_type,NULL ,NULL ); +// Server bit is 1 for ASN1_BIT_STRING_get_bit + result =ASN1_BIT_STRING_get_bit (ns,1 ) ?SUCCESS :FAILURE ;if (result ==SUCCESS ) { msg(M_WARN, "X509: Certificate is a server certificate yet it's purpose "
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1587?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I77500d435f212a4bf42ee8cfca07d0285fe694f2
Gerrit-Change-Number: 1587
Gerrit-PatchSet: 2
Gerrit-Owner: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1587?usp=email )
Change subject: Use ASN1_BIT_STRING_get_bit to check for netscape certificate usage
......................................................................
Patch Set 3: Code-Review-1
(2 comments)
Commit Message:
http://gerrit.openvpn.net/c/openvpn/+/1587/comment/a6196a88_86a2feb6?usp=email :
PS3, Line 13: The bit counting in ANS.1 and of this method is a bit strange and ASN
File src/openvpn/ssl_verify_openssl.c:
http://gerrit.openvpn.net/c/openvpn/+/1587/comment/8acc94f5_568890ee?usp=email :
PS3, Line 621: * case when its distribution will update to OpenSSL 1.1
This comments seems very obsolete? Apparently even newest OpenSSL allows us to make this check? The actual warning is probably fine since it just says "future", but the comment could clearly use some update?
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1587?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I77500d435f212a4bf42ee8cfca07d0285fe694f2
Gerrit-Change-Number: 1587
Gerrit-PatchSet: 3
Gerrit-Owner: plaisthos <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Comment-Date: Wed, 01 Apr 2026 10:24:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1587?usp=email )
Change subject: Use ASN1_BIT_STRING_get_bit to check for netscape certificate usage
......................................................................
Patch Set 3:
(1 comment)
File src/openvpn/ssl_verify_openssl.c:
http://gerrit.openvpn.net/c/openvpn/+/1587/comment/fd8dcdf5_7e06cd35?usp=email :
PS3, Line 621: * case when its distribution will update to OpenSSL 1.1
Quoted 1 line
This comments seems very obsolete? Apparently even newest OpenSSL allows us to make this check? The […]
Will clarify
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1587?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I77500d435f212a4bf42ee8cfca07d0285fe694f2
Gerrit-Change-Number: 1587
Gerrit-PatchSet: 3
Gerrit-Owner: plaisthos <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Comment-Date: Wed, 01 Apr 2026 11:28:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <[email protected]...>
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1587?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Code-Review-1 by flichtenheld
Change subject: Use ASN1_BIT_STRING_get_bit to check for netscape certificate usage
......................................................................
Use ASN1_BIT_STRING_get_bit to check for netscape certificate usage
The ASN_BIT_STRING object has become opaque in OpenSSL 4.0. So instead of accessing the internal, we have to use a method now to check these attributes.
The bit counting in ANS.1 and of this method is a bit strange and it will count bits from the left instead of the right, so the previous mask of 0x80 for clients is now 0 and 0x40 for server is now 1.
---
M src/openvpn/ssl_verify_openssl.c
1 file changed, 15 insertions(+), 12 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/87/1587/4
src/openvpn/ssl_verify_openssl.c +15 -12
@@ -609,22 +609,24 @@if (usage ==NS_CERT_CHECK_CLIENT ) {/* -* Unfortunately, X509_check_purpose() does some weird thing that +* Unfortunately, X509_check_purpose() before OpenSSL 4.0 does some weird thing that * prevent it to take a const argument */ result_t result =X509_check_purpose (peer_cert,X509_PURPOSE_SSL_CLIENT ,0 ) ?SUCCESS :FAILURE ;/* -* old versions of OpenSSL allow us to make the less strict check we used to -* do. If this less strict check pass, warn user that this might not be the -* case when its distribution will update to OpenSSL 1.1 +* Note that we do not check for netscape certificate type here but rather +* check for a gneral SSL/TLS client purpose. We do not know how long nscert +* attributes are accepted by TLS library in the future. Currently OpenSSL 4.0 +* and aws-lc 1.9.0 still consider nscert client as acceptable. */ if (result ==FAILURE ) {ASN1_BIT_STRING *ns; ns =X509_get_ext_d2i (peer_cert, NID_netscape_cert_type,NULL ,NULL ); - result = (ns &&ASN1_STRING_length (ns) >0 && (ASN1_STRING_get0_data (ns)[0 ] &NS_SSL_CLIENT )) ?SUCCESS :FAILURE ; +// bit 0 is to check if certificate is the client certificate + result =ASN1_BIT_STRING_get_bit (ns,0 ) ?SUCCESS :FAILURE ;if (result ==SUCCESS ) { msg(M_WARN, "X509: Certificate is a client certificate yet it's purpose "
@@ -637,22 +639,23 @@if (usage ==NS_CERT_CHECK_SERVER ) {/* -* Unfortunately, X509_check_purpose() does some weird thing that +* Unfortunately, X509_check_purpose() before OpenSSL 4.0 does some weird thing that * prevent it to take a const argument */ result_t result =X509_check_purpose (peer_cert,X509_PURPOSE_SSL_SERVER ,0 ) ?SUCCESS :FAILURE ;/* -* old versions of OpenSSL allow us to make the less strict check we used to -* do. If this less strict check pass, warn user that this might not be the -* case when its distribution will update to OpenSSL 1.1 +* Note that we do not check for netscape certificate type here but rather +* check for a gneral SSL/TLS server purpose. We do not know how long nscert +* attributes are accepted by TLS library in the future. Currently OpenSSL 4.0 +* and aws-lc 1.9.0 still consider nscert server as acceptable. */ if (result ==FAILURE ) { -ASN1_BIT_STRING *ns; - ns =X509_get_ext_d2i (peer_cert, NID_netscape_cert_type,NULL ,NULL ); - result = (ns &&ASN1_STRING_length (ns) >0 && (ASN1_STRING_get0_data (ns)[0 ] &NS_SSL_SERVER )) ?SUCCESS :FAILURE ; +ASN1_BIT_STRING *ns =X509_get_ext_d2i (peer_cert, NID_netscape_cert_type,NULL ,NULL ); +// Server bit is 1 for ASN1_BIT_STRING_get_bit + result =ASN1_BIT_STRING_get_bit (ns,1 ) ?SUCCESS :FAILURE ;if (result ==SUCCESS ) { msg(M_WARN, "X509: Certificate is a server certificate yet it's purpose "
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1587?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I77500d435f212a4bf42ee8cfca07d0285fe694f2
Gerrit-Change-Number: 1587
Gerrit-PatchSet: 4
Gerrit-Owner: plaisthos <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]...>
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1587?usp=email )
Change subject: Use ASN1_BIT_STRING_get_bit to check for netscape certificate usage
......................................................................
Patch Set 4: Code-Review-1
(3 comments)
File src/openvpn/ssl_verify_openssl.c:
http://gerrit.openvpn.net/c/openvpn/+/1587/comment/261d53a9_1d432fb9?usp=email :
PS4, Line 619: * Note that we do not check for netscape certificate type here but rather
This line of the comment appears to describe the check above?
http://gerrit.openvpn.net/c/openvpn/+/1587/comment/de76a3de_26cc4a05?usp=email :
PS4, Line 620: * check for a gneral SSL/TLS client purpose. We do not know how long nscert
general
http://gerrit.openvpn.net/c/openvpn/+/1587/comment/88061c4b_a2679e31?usp=email :
PS4, Line 621: * attributes are accepted by TLS library in the future. Currently OpenSSL 4.0
libraries
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1587?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I77500d435f212a4bf42ee8cfca07d0285fe694f2
Gerrit-Change-Number: 1587
Gerrit-PatchSet: 4
Gerrit-Owner: plaisthos <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Comment-Date: Wed, 01 Apr 2026 15:32:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1587?usp=email )
Change subject: Use ASN1_BIT_STRING_get_bit to check for netscape certificate usage
......................................................................
Patch Set 4:
(3 comments)
File src/openvpn/ssl_verify_openssl.c:
http://gerrit.openvpn.net/c/openvpn/+/1587/comment/9c1d6b68_eba94285?usp=email :
PS4, Line 619: * Note that we do not check for netscape certificate type here but rather
Quoted 1 line
This line of the comment appears to describe the check above?
Acknowledged
http://gerrit.openvpn.net/c/openvpn/+/1587/comment/da852456_6bac570a?usp=email :
PS4, Line 620: * check for a gneral SSL/TLS client purpose. We do not know how long nscert
Quoted 1 line
general
Acknowledged
http://gerrit.openvpn.net/c/openvpn/+/1587/comment/a5d1f69a_f10bf290?usp=email :
PS4, Line 621: * attributes are accepted by TLS library in the future. Currently OpenSSL 4.0
Quoted 1 line
libraries
Acknowledged
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1587?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I77500d435f212a4bf42ee8cfca07d0285fe694f2
Gerrit-Change-Number: 1587
Gerrit-PatchSet: 4
Gerrit-Owner: plaisthos <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Comment-Date: Thu, 02 Apr 2026 10:56:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <[email protected]...>
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1587?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Code-Review-1 by flichtenheld
Change subject: Use ASN1_BIT_STRING_get_bit to check for netscape certificate usage
......................................................................
Use ASN1_BIT_STRING_get_bit to check for netscape certificate usage
The ASN_BIT_STRING object has become opaque in OpenSSL 4.0. So instead of accessing the internal, we have to use a method now to check these attributes.
The bit counting in ANS.1 and of this method is a bit strange and it will count bits from the left instead of the right, so the previous mask of 0x80 for clients is now 0 and 0x40 for server is now 1.
---
M src/openvpn/ssl_verify_openssl.c
1 file changed, 23 insertions(+), 13 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/87/1587/5
src/openvpn/ssl_verify_openssl.c +23 -13
@@ -609,22 +609,27 @@if (usage ==NS_CERT_CHECK_CLIENT ) {/* -* Unfortunately, X509_check_purpose() does some weird thing that +* Unfortunately, X509_check_purpose() before OpenSSL 4.0 does some weird thing that * prevent it to take a const argument */ result_t result =X509_check_purpose (peer_cert,X509_PURPOSE_SSL_CLIENT ,0 ) ?SUCCESS :FAILURE ; -/* -* old versions of OpenSSL allow us to make the less strict check we used to -* do. If this less strict check pass, warn user that this might not be the -* case when its distribution will update to OpenSSL 1.1 +* Note that we did not check for netscape certificate type here but +* instead a general SSL/TLS client purpose. These nscert attributes +* might stop being accepted by TLS libraries in the future. +* Currently, OpenSSL 4.0 and aws-lc 1.9.0 still consider nscert client +* as acceptable. +* +* So in case that this check failed, we now check if this is caused +* by the check above no longer recognising nscert attributes. */ if (result ==FAILURE ) {ASN1_BIT_STRING *ns; ns =X509_get_ext_d2i (peer_cert, NID_netscape_cert_type,NULL ,NULL ); - result = (ns &&ASN1_STRING_length (ns) >0 && (ASN1_STRING_get0_data (ns)[0 ] &NS_SSL_CLIENT )) ?SUCCESS :FAILURE ; +// bit 0 is to check if certificate is the client certificate + result =ASN1_BIT_STRING_get_bit (ns,0 ) ?SUCCESS :FAILURE ;if (result ==SUCCESS ) { msg(M_WARN, "X509: Certificate is a client certificate yet it's purpose "
@@ -637,22 +642,27 @@if (usage ==NS_CERT_CHECK_SERVER ) {/* -* Unfortunately, X509_check_purpose() does some weird thing that +* Unfortunately, X509_check_purpose() before OpenSSL 4.0 does some weird thing that * prevent it to take a const argument */ result_t result =X509_check_purpose (peer_cert,X509_PURPOSE_SSL_SERVER ,0 ) ?SUCCESS :FAILURE ;/* -* old versions of OpenSSL allow us to make the less strict check we used to -* do. If this less strict check pass, warn user that this might not be the -* case when its distribution will update to OpenSSL 1.1 +* Note that we did not check for netscape certificate type here but +* instead a general SSL/TLS server purpose. These nscert attributes +* might stop being accepted by TLS libraries in the future. +* Currently, OpenSSL 4.0 and aws-lc 1.9.0 still consider nscert server +* as acceptable. +* +* So in case that this check failed, we now check if this is caused +* by the check above no longer recognising nscert attributes. */ if (result ==FAILURE ) { -ASN1_BIT_STRING *ns; - ns =X509_get_ext_d2i (peer_cert, NID_netscape_cert_type,NULL ,NULL ); - result = (ns &&ASN1_STRING_length (ns) >0 && (ASN1_STRING_get0_data (ns)[0 ] &NS_SSL_SERVER )) ?SUCCESS :FAILURE ; +ASN1_BIT_STRING *ns =X509_get_ext_d2i (peer_cert, NID_netscape_cert_type,NULL ,NULL ); +// Server bit is 1 for ASN1_BIT_STRING_get_bit + result =ASN1_BIT_STRING_get_bit (ns,1 ) ?SUCCESS :FAILURE ;if (result ==SUCCESS ) { msg(M_WARN, "X509: Certificate is a server certificate yet it's purpose "
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1587?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I77500d435f212a4bf42ee8cfca07d0285fe694f2
Gerrit-Change-Number: 1587
Gerrit-PatchSet: 5
Gerrit-Owner: plaisthos <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]...>
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1587?usp=email )
Change subject: Use ASN1_BIT_STRING_get_bit to check for netscape certificate usage
......................................................................
Patch Set 5: Code-Review-1
(1 comment)
Patchset:
PS5:
There is still the typo in the commit message
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1587?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I77500d435f212a4bf42ee8cfca07d0285fe694f2
Gerrit-Change-Number: 1587
Gerrit-PatchSet: 5
Gerrit-Owner: plaisthos <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Comment-Date: Thu, 02 Apr 2026 11:47:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1587?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Code-Review-1 by flichtenheld
Change subject: Use ASN1_BIT_STRING_get_bit to check for netscape certificate usage
......................................................................
Use ASN1_BIT_STRING_get_bit to check for netscape certificate usage
The ASN_BIT_STRING object has become opaque in OpenSSL 4.0. So instead of accessing the internal, we have to use a method now to check these attributes.
The bit counting in ASN.1 and of this method is a bit strange and it will count bits from the left instead of the right, so the previous mask of 0x80 for clients is now 0 and 0x40 for server is now 1.
---
M src/openvpn/ssl_verify_openssl.c
1 file changed, 23 insertions(+), 13 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/87/1587/6
src/openvpn/ssl_verify_openssl.c +23 -13
@@ -609,22 +609,27 @@if (usage ==NS_CERT_CHECK_CLIENT ) {/* -* Unfortunately, X509_check_purpose() does some weird thing that +* Unfortunately, X509_check_purpose() before OpenSSL 4.0 does some weird thing that * prevent it to take a const argument */ result_t result =X509_check_purpose (peer_cert,X509_PURPOSE_SSL_CLIENT ,0 ) ?SUCCESS :FAILURE ; -/* -* old versions of OpenSSL allow us to make the less strict check we used to -* do. If this less strict check pass, warn user that this might not be the -* case when its distribution will update to OpenSSL 1.1 +* Note that we did not check for netscape certificate type here but +* instead a general SSL/TLS client purpose. These nscert attributes +* might stop being accepted by TLS libraries in the future. +* Currently, OpenSSL 4.0 and aws-lc 1.9.0 still consider nscert client +* as acceptable. +* +* So in case that this check failed, we now check if this is caused +* by the check above no longer recognising nscert attributes. */ if (result ==FAILURE ) {ASN1_BIT_STRING *ns; ns =X509_get_ext_d2i (peer_cert, NID_netscape_cert_type,NULL ,NULL ); - result = (ns &&ASN1_STRING_length (ns) >0 && (ASN1_STRING_get0_data (ns)[0 ] &NS_SSL_CLIENT )) ?SUCCESS :FAILURE ; +// bit 0 is to check if certificate is the client certificate + result =ASN1_BIT_STRING_get_bit (ns,0 ) ?SUCCESS :FAILURE ;if (result ==SUCCESS ) { msg(M_WARN, "X509: Certificate is a client certificate yet it's purpose "
@@ -637,22 +642,27 @@if (usage ==NS_CERT_CHECK_SERVER ) {/* -* Unfortunately, X509_check_purpose() does some weird thing that +* Unfortunately, X509_check_purpose() before OpenSSL 4.0 does some weird thing that * prevent it to take a const argument */ result_t result =X509_check_purpose (peer_cert,X509_PURPOSE_SSL_SERVER ,0 ) ?SUCCESS :FAILURE ;/* -* old versions of OpenSSL allow us to make the less strict check we used to -* do. If this less strict check pass, warn user that this might not be the -* case when its distribution will update to OpenSSL 1.1 +* Note that we did not check for netscape certificate type here but +* instead a general SSL/TLS server purpose. These nscert attributes +* might stop being accepted by TLS libraries in the future. +* Currently, OpenSSL 4.0 and aws-lc 1.9.0 still consider nscert server +* as acceptable. +* +* So in case that this check failed, we now check if this is caused +* by the check above no longer recognising nscert attributes. */ if (result ==FAILURE ) { -ASN1_BIT_STRING *ns; - ns =X509_get_ext_d2i (peer_cert, NID_netscape_cert_type,NULL ,NULL ); - result = (ns &&ASN1_STRING_length (ns) >0 && (ASN1_STRING_get0_data (ns)[0 ] &NS_SSL_SERVER )) ?SUCCESS :FAILURE ; +ASN1_BIT_STRING *ns =X509_get_ext_d2i (peer_cert, NID_netscape_cert_type,NULL ,NULL ); +// Server bit is 1 for ASN1_BIT_STRING_get_bit + result =ASN1_BIT_STRING_get_bit (ns,1 ) ?SUCCESS :FAILURE ;if (result ==SUCCESS ) { msg(M_WARN, "X509: Certificate is a server certificate yet it's purpose "
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1587?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I77500d435f212a4bf42ee8cfca07d0285fe694f2
Gerrit-Change-Number: 1587
Gerrit-PatchSet: 6
Gerrit-Owner: plaisthos <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1587?usp=email )
Change subject: Use ASN1_BIT_STRING_get_bit to check for netscape certificate usage
......................................................................
Patch Set 6:
(1 comment)
Commit Message:
http://gerrit.openvpn.net/c/openvpn/+/1587/comment/d59c8f6b_50a3406d?usp=email :
PS3, Line 13: The bit counting in ANS.1 and of this method is a bit strange and
Quoted 1 line
ASN
Done
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1587?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I77500d435f212a4bf42ee8cfca07d0285fe694f2
Gerrit-Change-Number: 1587
Gerrit-PatchSet: 6
Gerrit-Owner: plaisthos <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Comment-Date: Thu, 02 Apr 2026 12:13:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <[email protected]...>
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1587?usp=email )
Change subject: Use ASN1_BIT_STRING_get_bit to check for netscape certificate usage
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1587?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I77500d435f212a4bf42ee8cfca07d0285fe694f2
Gerrit-Change-Number: 1587
Gerrit-PatchSet: 6
Gerrit-Owner: plaisthos <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Comment-Date: Thu, 02 Apr 2026 12:24:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
PATCH v6 1/1 Use ASN1_BIT_STRING_get_bit to check for netscape certificate usage
In reply to a message not in the archiveFrom: Arne Schwabe <[email protected]...>
The ASN_BIT_STRING object has become opaque in OpenSSL 4.0. So instead of accessing the internal, we have to use a method now to check these attributes.
The bit counting in ASN.1 and of this method is a bit strange and it will count bits from the left instead of the right, so the previous mask of 0x80 for clients is now 0 and 0x40 for server is now 1.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1587
---
This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1587
This mail reflects revision 6 of this Change.
Acked-by according to Gerrit (reflected above):
Frank Lichtenheld <[email protected]...>
src/openvpn/ssl_verify_openssl.c +23 -13
@@ -609,22 +609,27 @@if (usage ==NS_CERT_CHECK_CLIENT ) {/* -* Unfortunately, X509_check_purpose() does some weird thing that +* Unfortunately, X509_check_purpose() before OpenSSL 4.0 does some weird thing that * prevent it to take a const argument */ result_t result =X509_check_purpose (peer_cert,X509_PURPOSE_SSL_CLIENT ,0 ) ?SUCCESS :FAILURE ; -/* -* old versions of OpenSSL allow us to make the less strict check we used to -* do. If this less strict check pass, warn user that this might not be the -* case when its distribution will update to OpenSSL 1.1 +* Note that we did not check for netscape certificate type here but +* instead a general SSL/TLS client purpose. These nscert attributes +* might stop being accepted by TLS libraries in the future. +* Currently, OpenSSL 4.0 and aws-lc 1.9.0 still consider nscert client +* as acceptable. +* +* So in case that this check failed, we now check if this is caused +* by the check above no longer recognising nscert attributes. */ if (result ==FAILURE ) {ASN1_BIT_STRING *ns; ns =X509_get_ext_d2i (peer_cert, NID_netscape_cert_type,NULL ,NULL ); - result = (ns &&ASN1_STRING_length (ns) >0 && (ASN1_STRING_get0_data (ns)[0 ] &NS_SSL_CLIENT )) ?SUCCESS :FAILURE ; +// bit 0 is to check if certificate is the client certificate + result =ASN1_BIT_STRING_get_bit (ns,0 ) ?SUCCESS :FAILURE ;if (result ==SUCCESS ) { msg(M_WARN, "X509: Certificate is a client certificate yet it's purpose "
@@ -637,22 +642,27 @@if (usage ==NS_CERT_CHECK_SERVER ) {/* -* Unfortunately, X509_check_purpose() does some weird thing that +* Unfortunately, X509_check_purpose() before OpenSSL 4.0 does some weird thing that * prevent it to take a const argument */ result_t result =X509_check_purpose (peer_cert,X509_PURPOSE_SSL_SERVER ,0 ) ?SUCCESS :FAILURE ;/* -* old versions of OpenSSL allow us to make the less strict check we used to -* do. If this less strict check pass, warn user that this might not be the -* case when its distribution will update to OpenSSL 1.1 +* Note that we did not check for netscape certificate type here but +* instead a general SSL/TLS server purpose. These nscert attributes +* might stop being accepted by TLS libraries in the future. +* Currently, OpenSSL 4.0 and aws-lc 1.9.0 still consider nscert server +* as acceptable. +* +* So in case that this check failed, we now check if this is caused +* by the check above no longer recognising nscert attributes. */ if (result ==FAILURE ) { -ASN1_BIT_STRING *ns; - ns =X509_get_ext_d2i (peer_cert, NID_netscape_cert_type,NULL ,NULL ); - result = (ns &&ASN1_STRING_length (ns) >0 && (ASN1_STRING_get0_data (ns)[0 ] &NS_SSL_SERVER )) ?SUCCESS :FAILURE ; +ASN1_BIT_STRING *ns =X509_get_ext_d2i (peer_cert, NID_netscape_cert_type,NULL ,NULL ); +// Server bit is 1 for ASN1_BIT_STRING_get_bit + result =ASN1_BIT_STRING_get_bit (ns,1 ) ?SUCCESS :FAILURE ;if (result ==SUCCESS ) { msg(M_WARN, "X509: Certificate is a server certificate yet it's purpose "
[Openvpn-devel] [PATCH applied] Re: Use ASN1_BIT_STRING_get_bit to check for netscape certificate usage
Fortunately I do not need to understand any of this netscape cert purpose OpenSSL compat foo... but I do see an ACK from Frank, green builds in gerrit, and a localized change with good comment updates.
Mildly client-side tested on Linux, with OpenSSL 3.x.
As we agreed before, OpenSSL 4 compat is considered "long term compat" so goes to 2.7 as well.
Your patch has been applied to the master and release/2.7 branch.
commit 8ce6f8d166acf02d6833b9f37fb5cd2ca903a4a5 (master) commit 86d272cd6d30ece26e34482f9be02de6744e3694 (release/2.7)
Author: Arne Schwabe Date: Sat Apr 4 09:23:30 2026 +0200
Use ASN1_BIT_STRING_get_bit to check for netscape certificate usage
Signed-off-by: Arne Schwabe <[email protected]...>
Acked-by: Frank Lichtenheld <[email protected]...>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1587
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg36446.html
Signed-off-by: Gert Doering <[email protected]...>--
kind regards,
Gert Doering
cron2 has uploaded a new patch set (#7) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1587?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by flichtenheld
Change subject: Use ASN1_BIT_STRING_get_bit to check for netscape certificate usage
......................................................................
Use ASN1_BIT_STRING_get_bit to check for netscape certificate usage
The ASN_BIT_STRING object has become opaque in OpenSSL 4.0. So instead of accessing the internal, we have to use a method now to check these attributes.
The bit counting in ASN.1 and of this method is a bit strange and it will count bits from the left instead of the right, so the previous mask of 0x80 for clients is now 0 and 0x40 for server is now 1.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1587
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg36446.html
---
M src/openvpn/ssl_verify_openssl.c
1 file changed, 23 insertions(+), 13 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/87/1587/7
src/openvpn/ssl_verify_openssl.c +23 -13
@@ -609,22 +609,27 @@if (usage ==NS_CERT_CHECK_CLIENT ) {/* -* Unfortunately, X509_check_purpose() does some weird thing that +* Unfortunately, X509_check_purpose() before OpenSSL 4.0 does some weird thing that * prevent it to take a const argument */ result_t result =X509_check_purpose (peer_cert,X509_PURPOSE_SSL_CLIENT ,0 ) ?SUCCESS :FAILURE ; -/* -* old versions of OpenSSL allow us to make the less strict check we used to -* do. If this less strict check pass, warn user that this might not be the -* case when its distribution will update to OpenSSL 1.1 +* Note that we did not check for netscape certificate type here but +* instead a general SSL/TLS client purpose. These nscert attributes +* might stop being accepted by TLS libraries in the future. +* Currently, OpenSSL 4.0 and aws-lc 1.9.0 still consider nscert client +* as acceptable. +* +* So in case that this check failed, we now check if this is caused +* by the check above no longer recognising nscert attributes. */ if (result ==FAILURE ) {ASN1_BIT_STRING *ns; ns =X509_get_ext_d2i (peer_cert, NID_netscape_cert_type,NULL ,NULL ); - result = (ns &&ASN1_STRING_length (ns) >0 && (ASN1_STRING_get0_data (ns)[0 ] &NS_SSL_CLIENT )) ?SUCCESS :FAILURE ; +// bit 0 is to check if certificate is the client certificate + result =ASN1_BIT_STRING_get_bit (ns,0 ) ?SUCCESS :FAILURE ;if (result ==SUCCESS ) { msg(M_WARN, "X509: Certificate is a client certificate yet it's purpose "
@@ -637,22 +642,27 @@if (usage ==NS_CERT_CHECK_SERVER ) {/* -* Unfortunately, X509_check_purpose() does some weird thing that +* Unfortunately, X509_check_purpose() before OpenSSL 4.0 does some weird thing that * prevent it to take a const argument */ result_t result =X509_check_purpose (peer_cert,X509_PURPOSE_SSL_SERVER ,0 ) ?SUCCESS :FAILURE ;/* -* old versions of OpenSSL allow us to make the less strict check we used to -* do. If this less strict check pass, warn user that this might not be the -* case when its distribution will update to OpenSSL 1.1 +* Note that we did not check for netscape certificate type here but +* instead a general SSL/TLS server purpose. These nscert attributes +* might stop being accepted by TLS libraries in the future. +* Currently, OpenSSL 4.0 and aws-lc 1.9.0 still consider nscert server +* as acceptable. +* +* So in case that this check failed, we now check if this is caused +* by the check above no longer recognising nscert attributes. */ if (result ==FAILURE ) { -ASN1_BIT_STRING *ns; - ns =X509_get_ext_d2i (peer_cert, NID_netscape_cert_type,NULL ,NULL ); - result = (ns &&ASN1_STRING_length (ns) >0 && (ASN1_STRING_get0_data (ns)[0 ] &NS_SSL_SERVER )) ?SUCCESS :FAILURE ; +ASN1_BIT_STRING *ns =X509_get_ext_d2i (peer_cert, NID_netscape_cert_type,NULL ,NULL ); +// Server bit is 1 for ASN1_BIT_STRING_get_bit + result =ASN1_BIT_STRING_get_bit (ns,1 ) ?SUCCESS :FAILURE ;if (result ==SUCCESS ) { msg(M_WARN, "X509: Certificate is a server certificate yet it's purpose "
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1587?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I77500d435f212a4bf42ee8cfca07d0285fe694f2
Gerrit-Change-Number: 1587
Gerrit-PatchSet: 7
Gerrit-Owner: plaisthos <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1587?usp=email )
Change subject: Use ASN1_BIT_STRING_get_bit to check for netscape certificate usage
......................................................................
Use ASN1_BIT_STRING_get_bit to check for netscape certificate usage
The ASN_BIT_STRING object has become opaque in OpenSSL 4.0. So instead of accessing the internal, we have to use a method now to check these attributes.
The bit counting in ASN.1 and of this method is a bit strange and it will count bits from the left instead of the right, so the previous mask of 0x80 for clients is now 0 and 0x40 for server is now 1.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1587
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg36446.html
---
M src/openvpn/ssl_verify_openssl.c
1 file changed, 23 insertions(+), 13 deletions(-)
src/openvpn/ssl_verify_openssl.c +23 -13
@@ -609,22 +609,27 @@if (usage ==NS_CERT_CHECK_CLIENT ) {/* -* Unfortunately, X509_check_purpose() does some weird thing that +* Unfortunately, X509_check_purpose() before OpenSSL 4.0 does some weird thing that * prevent it to take a const argument */ result_t result =X509_check_purpose (peer_cert,X509_PURPOSE_SSL_CLIENT ,0 ) ?SUCCESS :FAILURE ; -/* -* old versions of OpenSSL allow us to make the less strict check we used to -* do. If this less strict check pass, warn user that this might not be the -* case when its distribution will update to OpenSSL 1.1 +* Note that we did not check for netscape certificate type here but +* instead a general SSL/TLS client purpose. These nscert attributes +* might stop being accepted by TLS libraries in the future. +* Currently, OpenSSL 4.0 and aws-lc 1.9.0 still consider nscert client +* as acceptable. +* +* So in case that this check failed, we now check if this is caused +* by the check above no longer recognising nscert attributes. */ if (result ==FAILURE ) {ASN1_BIT_STRING *ns; ns =X509_get_ext_d2i (peer_cert, NID_netscape_cert_type,NULL ,NULL ); - result = (ns &&ASN1_STRING_length (ns) >0 && (ASN1_STRING_get0_data (ns)[0 ] &NS_SSL_CLIENT )) ?SUCCESS :FAILURE ; +// bit 0 is to check if certificate is the client certificate + result =ASN1_BIT_STRING_get_bit (ns,0 ) ?SUCCESS :FAILURE ;if (result ==SUCCESS ) { msg(M_WARN, "X509: Certificate is a client certificate yet it's purpose "
@@ -637,22 +642,27 @@if (usage ==NS_CERT_CHECK_SERVER ) {/* -* Unfortunately, X509_check_purpose() does some weird thing that +* Unfortunately, X509_check_purpose() before OpenSSL 4.0 does some weird thing that * prevent it to take a const argument */ result_t result =X509_check_purpose (peer_cert,X509_PURPOSE_SSL_SERVER ,0 ) ?SUCCESS :FAILURE ;/* -* old versions of OpenSSL allow us to make the less strict check we used to -* do. If this less strict check pass, warn user that this might not be the -* case when its distribution will update to OpenSSL 1.1 +* Note that we did not check for netscape certificate type here but +* instead a general SSL/TLS server purpose. These nscert attributes +* might stop being accepted by TLS libraries in the future. +* Currently, OpenSSL 4.0 and aws-lc 1.9.0 still consider nscert server +* as acceptable. +* +* So in case that this check failed, we now check if this is caused +* by the check above no longer recognising nscert attributes. */ if (result ==FAILURE ) { -ASN1_BIT_STRING *ns; - ns =X509_get_ext_d2i (peer_cert, NID_netscape_cert_type,NULL ,NULL ); - result = (ns &&ASN1_STRING_length (ns) >0 && (ASN1_STRING_get0_data (ns)[0 ] &NS_SSL_SERVER )) ?SUCCESS :FAILURE ; +ASN1_BIT_STRING *ns =X509_get_ext_d2i (peer_cert, NID_netscape_cert_type,NULL ,NULL ); +// Server bit is 1 for ASN1_BIT_STRING_get_bit + result =ASN1_BIT_STRING_get_bit (ns,1 ) ?SUCCESS :FAILURE ;if (result ==SUCCESS ) { msg(M_WARN, "X509: Certificate is a server certificate yet it's purpose "
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1587?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I77500d435f212a4bf42ee8cfca07d0285fe694f2
Gerrit-Change-Number: 1587
Gerrit-PatchSet: 7
Gerrit-Owner: plaisthos <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>